Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashboard): update TiDB Dashboard to v8.3.0-e6e78c7c [master] #8420

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore(dashboard): update TiDB Dashboard to v8.3.0-e6e78c7c [master] #8420

merged 1 commit into from
Jul 18, 2024

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Jul 18, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4257

Update TiDB Dashboard to v8.3.0-e6e78c7c.

Release note

None

Test

$ make pd-server
$ cp bin/pd-server ~/.tiup/components/pd/v8.2.0-alpha-nightly/pd-server

# pd ms mode
$ tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 1 --pd.tso 1 --pd.rm 0 --kv 3 --tiflash 0 --db 1

# pd non-ms mode
$ tiup playground nightly --tiflash 0

image

image

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2024
@rleungx
Copy link
Member

rleungx commented Jul 18, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (c65577c) to head (fdb7138).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8420      +/-   ##
==========================================
+ Coverage   77.28%   77.35%   +0.07%     
==========================================
  Files         471      471              
  Lines       61878    61878              
==========================================
+ Hits        47823    47868      +45     
+ Misses      10470    10425      -45     
  Partials     3585     3585
Flag Coverage Δ
unittests 77.35% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 18, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 09:31:44.141688331 +0000 UTC m=+519126.132629799: ☑️ agreed by rleungx.
  • 2024-07-18 10:04:11.926157946 +0000 UTC m=+521073.917099417: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit 3bb69e6 into tikv:master Jul 18, 2024
26 checks passed
@baurine baurine deleted the update-tidb-dashboard/master-v8.3.0-e6e78c7c-1721294313 branch July 18, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baurine @rleungx @HuSharp